Merge branch 'task/JAL-3805_Remove_Uninstall_Old_Jalview_application_for_develop_bran...
authorJalview Development Admin <jalview-dev-owner@jalview.org>
Thu, 28 Jan 2021 13:50:45 +0000 (13:50 +0000)
committerJalview Development Admin <jalview-dev-owner@jalview.org>
Thu, 28 Jan 2021 13:50:45 +0000 (13:50 +0000)
1  2 
build.gradle
utils/install4j/install4j8_template.install4j

diff --combined build.gradle
@@@ -1837,12 -1837,6 +1837,6 @@@ task copyInstall4jTemplate 
        }
      }
  
-     // remove the "Uninstall Old Jalview (optional)" symlink from DMG for non-release DS_Stores
-     if (! (CHANNEL == "RELEASE" || CHANNEL == "TEST-RELEASE" ) ) {
-       def symlink = install4jConfigXml.'**'.topLevelFiles.symlink.find { sl -> sl.'@name' == "Uninstall Old Jalview (optional).app" }
-       symlink.parent().remove(symlink)
-     }
      // write install4j file
      install4jConfFile.text = XmlUtil.serialize(install4jConfigXml)
    }
@@@ -1883,8 -1877,6 +1877,8 @@@ task installers(type: com.install4j.gra
      'JALVIEW_APPLICATION_NAME': install4jApplicationName,
      'JALVIEW_DIR': "../..",
      'OSX_KEYSTORE': OSX_KEYSTORE,
 +    'OSX_APPLEID': OSX_APPLEID,
 +    'OSX_ALTOOLPASS': OSX_ALTOOLPASS,
      'JSIGN_SH': JSIGN_SH,
      'JRE_DIR': getdown_app_dir_java,
      'INSTALLER_TEMPLATE_VERSION': install4jTemplateVersion,
    if (install4j_faster.equals("true") || CHANNEL.startsWith("LOCAL")) {
      faster = true
      disableSigning = true
 +    disableNotarization = true
    }
  
    if (OSX_KEYPASS) {
      macKeystorePassword = OSX_KEYPASS
 +  } 
 +  
 +  if (OSX_ALTOOLPASS) {
 +    appleIdPassword = OSX_ALTOOLPASS
 +    disableNotarization = false
 +  } else {
 +    disableNotarization = true
    }
  
    doFirst {
      println("Using projectFile "+projectFile)
 +    if (!disableNotarization) { println("Will notarize OSX App DMG") }
    }
 +  verbose=true
  
    inputs.dir(getdownWebsiteDir)
    inputs.file(install4jConfFile)
@@@ -1,5 -1,5 +1,5 @@@
  <?xml version="1.0" encoding="UTF-8"?>
 -<install4j version="8.0.8" transformSequenceNumber="8">
 +<install4j version="8.0.10" transformSequenceNumber="8">
    <directoryPresets config="../.." />
    <application name="${compiler:JALVIEW_APPLICATION_NAME}" applicationId="${compiler:WINDOWS_APPLICATION_ID}" mediaDir="${compiler:BUILD_DIR}" lzmaCompression="true" shortName="${compiler:INTERNAL_ID}" publisher="University of Dundee" publisherWeb="https://www.jalview.org/" version="${compiler:JALVIEW_VERSION}" allPathsRelative="true" macVolumeId="5aac4968c304f65" javaMinVersion="${compiler:JAVA_MIN_VERSION}" javaMaxVersion="9999999999${compiler:JAVA_MAX_VERSION}" allowBetaVM="true" jdkMode="jdk" jdkName="JDK 11.0">
      <searchSequence>
@@@ -13,7 -13,6 +13,7 @@@
        <variable name="JALVIEW_DIR" value="../.." />
        <variable name="BUILD_DIR" value="${compiler:JALVIEW_DIR}/build/install4j" />
        <variable name="OSX_KEYSTORE" />
 +      <variable name="OSX_APPLEID" />
        <variable name="JSIGN_SH" value="echo" />
        <variable name="JRE_DIR" value="jre" description="The folder under the app folder that the JRE will be either copied or unpacked into" />
        <variable name="INSTALLER_TEMPLATE_VERSION" value="DEVELOPMENT_default" />
@@@ -33,7 -32,7 +33,7 @@@
        <variable name="BUNDLE_ID" value="org.jalview.jalview-desktop" />
        <variable name="INTERNAL_ID" value="Jalview" />
        <variable name="WINDOWS_APPLICATION_ID" value="6595-2347-1923-0725" />
-       <variable name="MACOS_DMG_DS_STORE" value="DS_Store" />
+       <variable name="MACOS_DMG_DS_STORE" value="jalview_dmg_DS_Store" />
        <variable name="MACOS_DMG_BG_IMAGE" />
        <variable name="INSTALLER_NAME" value="Jalview Installer" />
        <variable name="INSTALL4J_UTILS_DIR" value="utils/install4j" />
        <variable name="PNG_ICON_FILE" value="utils/channels/release/images/jalview_logo.png" />
        <variable name="BACKGROUND" value="utils/channels/release/images/jalview_logo_background_fade-640x480.png" />
      </variables>
 -    <codeSigning macEnabled="true" macPkcs12File="${compiler:OSX_KEYSTORE}" />
 +    <codeSigning macEnabled="true" macPkcs12File="${compiler:OSX_KEYSTORE}" macNotarize="true" appleId="${compiler:OSX_APPLEID}">
 +      <macAdditionalBinaries>
 +        <entry>*.dylib</entry>
 +        <entry>*.so</entry>
 +        <entry>*.jnilib</entry>
 +        <entry>unpack200</entry>
 +        <entry>tnameserv</entry>
 +        <entry>servertool</entry>
 +        <entry>rmiregistry</entry>
 +        <entry>rmid</entry>
 +        <entry>policytool</entry>
 +        <entry>pack200</entry>
 +        <entry>orbd</entry>
 +        <entry>keytool</entry>
 +        <entry>jjs</entry>
 +        <entry>java</entry>
 +        <entry>jspawnhelper</entry>
 +        <entry>libfreetype.dylib.6</entry>
 +        <entry>applet</entry>
 +      </macAdditionalBinaries>
 +    </codeSigning>
    </application>
    <files defaultUninstallMode="2">
      <filesets>
        <fileset name="Mac OS X JRE" id="880" />
        <fileset name="Windows JRE" id="882" />
        <fileset name="Jalview application" id="1873" />
-       <fileset name="MacOS Old Jalview Uninstaller" id="2105" />
      </filesets>
      <roots>
        <root id="735" fileset="734" />
        <root id="881" fileset="880" />
        <root id="883" fileset="882" />
        <root id="1874" fileset="1873" />
-       <root id="2106" fileset="2105" />
      </roots>
      <mountPoints>
        <mountPoint id="454" />
@@@ -97,7 -74,6 +95,6 @@@
        <mountPoint id="884" root="881" />
        <mountPoint id="885" root="883" />
        <mountPoint id="1875" root="1874" />
-       <mountPoint id="2107" root="2106" />
      </mountPoints>
      <entries>
        <dirEntry mountPoint="454" file="${compiler:JALVIEW_DIR}/${compiler:GETDOWN_FILES_DIR}/${compiler:JAVA_VERSION}" uninstallMode="2" overrideOverwriteMode="true" overrideUninstallMode="true" subDirectory="files" />
        <dirEntry mountPoint="884" file="${compiler:MACOS_JAVA_VM_DIR}" fileMode="755" overrideFileMode="true" overrideUninstallMode="true" entryMode="subdir" subDirectory="${compiler:JRE_DIR}" />
        <dirEntry mountPoint="885" file="${compiler:WINDOWS_JAVA_VM_DIR}" fileMode="755" overrideFileMode="true" overrideUninstallMode="true" entryMode="subdir" subDirectory="${compiler:JRE_DIR}" />
        <dirEntry mountPoint="1875" file="${compiler:JALVIEW_DIR}/${compiler:GETDOWN_WEBSITE_DIR}/${compiler:JAVA_VERSION}/${compiler:GETDOWN_DIST_DIR}" overwriteMode="1" uninstallMode="2" overrideFileMode="true" overrideOverwriteMode="true" overrideUninstallMode="true" entryMode="subdir" subDirectory="${compiler:GETDOWN_DIST_DIR}" overrideDirMode="true" />
-       <dirEntry mountPoint="2107" file="Uninstall Old Jalview.app" fileMode="755" overrideFileMode="true" entryMode="subdir" subDirectory="Uninstall Old Jalview.app" overrideDirMode="true" />
      </entries>
      <components>
        <component name="jalview_getdown" id="1031">
            <entry filesetId="1873" />
          </include>
        </component>
-       <component name="macos_old_jalview_uninstaller" id="2110">
-         <include>
-           <entry filesetId="2105" />
-         </include>
-       </component>
      </components>
    </files>
    <launchers>
@@@ -1155,7 -1125,6 +1146,6 @@@ return console.askYesNo(message, true)
          <component id="1156" />
          <component id="1276" />
          <component id="1881" />
-         <component id="2110" />
        </excludedComponents>
        <exclude>
          <entry defaultFileset="true" />
          <file name=".DS_Store" file="${compiler:JALVIEW_DIR}/${compiler:MACOS_DMG_DS_STORE}" />
          <file name="${compiler:JALVIEW_APPLICATION_NAME}.app/Contents/Resources/Jalview-File.icns" file="${compiler:JALVIEW_DIR}/${compiler:INSTALL4J_UTILS_DIR}/Jalview-File.icns" />
          <file name="${compiler:JALVIEW_APPLICATION_NAME}.app/Contents/Resources/Jalview-Launch.icns" file="${compiler:JALVIEW_DIR}/${compiler:INSTALL4J_UTILS_DIR}/Jalview-Launch.icns" />
-         <symlink name="Uninstall Old Jalview (optional).app" target="${compiler:JALVIEW_APPLICATION_NAME}.app/Contents/Resources/app/Uninstall Old Jalview.app" />
        </topLevelFiles>
      </macosArchive>
      <unixInstaller name="Linux x64 Shell Installer" id="1595" mediaFileName="${compiler:UNIX_APPLICATION_FOLDER}-${compiler:JALVIEW_VERSION}-linux_x64-java_${compiler:JAVA_INTEGER_VERSION}" installDir="${compiler:UNIX_APPLICATION_FOLDER}" customInstallBaseDir="~/opt/">
          <component id="1156" />
          <component id="1276" />
          <component id="1881" />
-         <component id="2110" />
        </excludedComponents>
        <exclude>
          <entry defaultFileset="true" />
          <component id="1156" />
          <component id="1276" />
          <component id="1881" />
-         <component id="2110" />
        </excludedComponents>
        <exclude>
          <entry defaultFileset="true" />
          <component id="1156" />
          <component id="1276" />
          <component id="1881" />
-         <component id="2110" />
        </excludedComponents>
        <exclude>
          <entry defaultFileset="true" />