git://source.jalview.org / jalview.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 7d34fe9)
JAL-2213 made RESNUM constant private (not used elsewhere) to reduce
authorgmungoc <g.m.carstairs@dundee.ac.uk>
Thu, 29 Sep 2016 12:17:53 +0000 (13:17 +0100)
committergmungoc <g.m.carstairs@dundee.ac.uk>
Thu, 29 Sep 2016 12:17:53 +0000 (13:17 +0100)
confusion

src/jalview/io/PDBFeatureSettings.java patch | blob | history

diff --git a/src/jalview/io/PDBFeatureSettings.java b/src/jalview/io/PDBFeatureSettings.java
index ecce1a3..5294c45 100644 (file)
--- a/src/jalview/io/PDBFeatureSettings.java
+++ b/src/jalview/io/PDBFeatureSettings.java
@@ -8,10 +8,10 @@ import java.awt.Color;
 
 public class PDBFeatureSettings extends FeatureSettingsAdapter
 {
+  // TODO find one central place to define feature names
+  private static final String FEATURE_INSERTION = "INSERTION";
 
-  public static final String FEATURE_INSERTION = "INSERTION";
-
-  public static final String FEATURE_RES_NUM = "RESNUM";
+  private static final String FEATURE_RES_NUM = "RESNUM";
 
   @Override
   public boolean isFeatureDisplayed(String type)